Skip to content

Host github.com works, Host *.github.com does not#23513

Merged
sophietheking merged 2 commits intogithub:mainfrom
simonw:patch-1
Feb 7, 2023
Merged

Host github.com works, Host *.github.com does not#23513
sophietheking merged 2 commits intogithub:mainfrom
simonw:patch-1

Conversation

@simonw
Copy link
Copy Markdown
Contributor

@simonw simonw commented Jan 27, 2023

Why:

Closes #23512

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fixed the example for ~/.ssh/config.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 27, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jan 27, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 27, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Jan 27, 2023

@simonw Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review ssh Content related to SSH authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Jan 27, 2023
sophietheking
sophietheking approved these changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonw thanks for contributing to our Docs! Your change looks good, so I'll make sure tests are passing and will get this merged for you. 💖

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 7, 2023
@sophietheking sophietheking merged commit 9fe18d8 into github:main Feb 7, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@sophietheking sophietheking mentioned this pull request Feb 7, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees

No one assigned

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge ssh Content related to SSH

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding your SSH key to the ssh-agent instructions are incorrect

4 participants

@simonw @cmwilson21 @sophietheking @docubot